[PATCH] Fix hardcoded stack probe space

David Majnemer david.majnemer at gmail.com
Sat Jan 3 17:24:13 PST 2015


This is looking great so far.

Please update the LangRef with your new function attribute, the file is docs/LangRef.rst.

It should go with all the others: http://llvm.org/docs/LangRef.html#function-attributes
Be sure to mention that this attribute only has an effect on specific targets (MingW, Cygwin, MSVC) and that other targets will ignore the attribute.


REPOSITORY
  rL LLVM

================
Comment at: lib/Target/X86/X86FrameLowering.cpp:532-533
@@ -530,1 +531,4 @@
 
+  if (Fn->hasFnAttribute(Attribute::StackProbeSize))
+  {
+    Attribute A = Fn->getFnAttribute(Attribute::StackProbeSize);
----------------
Please format this according to the style guide, the brace should be on the same line as the if.

================
Comment at: lib/Target/X86/X86Subtarget.h:237
@@ +236,3 @@
+  /// used if the function has no stackprobesize attribute.
+  unsigned defaultStackProbeSize;
+
----------------
This should start with a capital letter.

http://reviews.llvm.org/D6684

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list