[PATCH] [compiler-rt] atos symbolizer for OS X

[Kuba Brecka]

Addressing review comments.

> As far as I can tell, both ExtractInt and ExtractUptr are used to extract unsigned integers. Why use both (and deal with the potential overflow situations)?


Removed ExtractInt and kept only ExtractUptr.

> > prefix_end += internal_strlen(delimiter);

>  Isn't that just prefix_len?


No, this line moves the pointer *after* the delimiter (if one was found), I think we really need `strlen(delimiter)` here.

> Wonder if we want/should check that exactly the required symbolizer is being used (e.g. print its name under verbosity=2)


Good idea. Added.


http://reviews.llvm.org/D6588

Files:
  lib/sanitizer_common/CMakeLists.txt
  lib/sanitizer_common/sanitizer_common.cc
  lib/sanitizer_common/sanitizer_common.h
  lib/sanitizer_common/sanitizer_symbolizer.h
  lib/sanitizer_common/sanitizer_symbolizer_libbacktrace.cc
  lib/sanitizer_common/sanitizer_symbolizer_libbacktrace.h
  lib/sanitizer_common/sanitizer_symbolizer_mac.cc
  lib/sanitizer_common/sanitizer_symbolizer_mac.h
  lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc
  test/asan/TestCases/Darwin/sandbox-symbolizer.cc
  test/asan/TestCases/Darwin/suppressions-sandbox.cc
  test/asan/TestCases/closed-fds.cc

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6588.17728.patch
Type: text/x-patch
Size: 47131 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141230/4ddb534b/attachment.bin>