[PATCH] Add a new matcher m_ICmpWithPred

[Philip Reames]

LGTM

Refactoring some bit of code as part of the patch so that this isn't dead on submission would be a good idea.  There should be lots of candidates.


================
Comment at: include/llvm/IR/PatternMatch.h:738
@@ -719,1 +737,3 @@
 
+template<ICmpInst::Predicate P, typename LHS, typename RHS>
+inline CmpClassPred_match<LHS, RHS, ICmpInst, ICmpInst::Predicate, P>
----------------
Add a comment which clarifies the difference with the previous, it's not obvious.

Something along the lines of:

/// Matches an arbitrary ICmp and binds Pred
.. matcher 1
/// Matches an icmp w/ a specific predicate P
... matcher 2

http://reviews.llvm.org/D6692

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/