[PATCH] [cmake/multilib] Teach llgo to respect the LLVM_LIBDIR_SUFFIX variable formultilib build and installs.

Chandler Carruth chandlerc at gmail.com
Mon Dec 29 11:04:21 PST 2014


On Mon, Dec 29, 2014 at 6:40 AM, Peter Collingbourne <peter at pcc.me.uk>
wrote:

> Did you end up exposing `LLVM_LIBDIR_SUFFIX` somewhere like a `#define` in
> a header file? If so, we should be able to pick it up from Go (see e.g.
> `bindings/go/llvm/version.go` for an example of how to do that).
>

I don't think this is the right design. The libdir suffix shouldn't be
exposed via a header, it should be exposed via the build system
(potentially through an invocation of llvm-config or inclusion of
LLVMConfig.cmake). As an example of why, it doesn't seem unreasonable for a
packager to install both lib32 and lib64 multilib variants of LLVM and
expect them to share the same installed header files.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141229/c33e77d0/attachment.html>


More information about the llvm-commits mailing list