[PATCH] [X86] Convert esp-relative movs of function arguments to pushes, step 2

Michael Kuperstein michael.m.kuperstein at intel.com
Sun Dec 28 06:11:42 PST 2014


Hi nadav, rnk, delena,

This is a first stab at the next step of the mov-to-push transformation.

It moves the transformation earlier in the pass order so that it can do load-folding, and prepares the required infrastructure. 
It is still enabled only in cases where it should be a clear win - when we don't expect to have a reserved call frame, or when optimizing for size. 
The next step will be a heuristic that makes a smarter decision on when this should be enabled. 

As a side note - I've done some internal testing for effects on the code size, but I'd like to do some testing for things other people care about as well. So, if you have a x86-32 code-base where you care about the code size, and is publicly available, let me know.

http://reviews.llvm.org/D6789

Files:
  lib/Target/X86/CMakeLists.txt
  lib/Target/X86/X86.h
  lib/Target/X86/X86ConvertMovsToPushes.cpp
  lib/Target/X86/X86FastISel.cpp
  lib/Target/X86/X86FrameLowering.cpp
  lib/Target/X86/X86FrameLowering.h
  lib/Target/X86/X86InstrCompiler.td
  lib/Target/X86/X86MachineFunctionInfo.h
  lib/Target/X86/X86TargetMachine.cpp
  test/CodeGen/X86/inalloca-invoke.ll
  test/CodeGen/X86/movtopush.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6789.17656.patch
Type: text/x-patch
Size: 31487 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141228/b7c749c7/attachment.bin>


More information about the llvm-commits mailing list