[PATCH] Add a helpful assert if LineNo would clobber ArgNo

Keno Fischer kfischer at college.harvard.edu
Sat Dec 27 05:25:06 PST 2014


Also just saw this email again (which for some reason doesn't show up in
the web interface?). I think I'd like somebody who knows more about the
debugging to make a choice here.

On Mon, Nov 10, 2014 at 4:59 AM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

>
> > On 2014 Nov 9, at 13:34, Keno Fischer <kfischer at college.harvard.edu>
> wrote:
> >
> > Hi echristo,
> >
> > Otherwise passing in an invalid line number on accident (e.g. -1)
> > would cause a hard-to-decipher assert later on. Better to catch this
> early.
> >
> > http://reviews.llvm.org/D6186
> >
> > Files:
> >  lib/IR/DIBuilder.cpp
>
> I think this should degrade (maybe to ~0u>>8?) rather than asserting.
>
> Thoughts?
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141227/e2dde378/attachment.html>


More information about the llvm-commits mailing list