[PATCH] [llvm-c] Expose getFunctionAddress, as a modern alternative

Peter Zotov whitequark at whitequark.org
Mon Dec 22 10:23:51 PST 2014


Since getPointerToGlobal was equivalent to getGlobalValueAddress, you should at least expose both getGlobalValueAddress and getFunctionAddress.


================
Comment at: lib/ExecutionEngine/ExecutionEngineBindings.cpp:332
@@ +331,3 @@
+uint64_t LLVMGetFunctionAddress(LLVMExecutionEngineRef EE, const char *Name) {
+  unwrap(EE)->finalizeObject();
+
----------------
Is this really necessary?

"Clients that intend to execute code locally can use the getFunctionAddress call, which will generate code and apply final preparations all in one step."

http://reviews.llvm.org/D6760

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list