[compiler-rt] r224710 - [ASan] Fix the logic that decides whether we need to spawn a new llvm-symbolizer in asan_symbolize.py

Alexander Potapenko glider at google.com
Mon Dec 22 08:00:00 PST 2014


Author: glider
Date: Mon Dec 22 10:00:00 2014
New Revision: 224710

URL: http://llvm.org/viewvc/llvm-project?rev=224710&view=rev
Log:
[ASan] Fix the logic that decides whether we need to spawn a new llvm-symbolizer in asan_symbolize.py

Modified:
    compiler-rt/trunk/lib/asan/scripts/asan_symbolize.py

Modified: compiler-rt/trunk/lib/asan/scripts/asan_symbolize.py
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/scripts/asan_symbolize.py?rev=224710&r1=224709&r2=224710&view=diff
==============================================================================
--- compiler-rt/trunk/lib/asan/scripts/asan_symbolize.py (original)
+++ compiler-rt/trunk/lib/asan/scripts/asan_symbolize.py Mon Dec 22 10:00:00 2014
@@ -366,12 +366,12 @@ class SymbolizationLoop(object):
     #  3. otherwise create a new symbolizer and pass all currently known
     #     .dSYM hints to it.
     if not binary in self.llvm_symbolizers:
-      use_last_symbolizer = True
+      use_new_symbolizer = True
       if self.system == 'Darwin' and self.dsym_hint_producer:
         dsym_hints_for_binary = set(self.dsym_hint_producer(binary))
-        use_last_symbolizer = bool(dsym_hints_for_binary - self.dsym_hints)
+        use_new_symbolizer = bool(dsym_hints_for_binary - self.dsym_hints)
         self.dsym_hints |= dsym_hints_for_binary
-      if self.last_llvm_symbolizer and use_last_symbolizer:
+      if self.last_llvm_symbolizer and not use_new_symbolizer:
           self.llvm_symbolizers[binary] = self.last_llvm_symbolizer
       else:
         self.last_llvm_symbolizer = LLVMSymbolizerFactory(





More information about the llvm-commits mailing list