[llvm] r223774 - [x86] Fix the test to actually test things for the CPU names, add the

[Justin Bogner]

> On Dec 19, 2014, at 17:37, Chandler Carruth <chandlerc at gmail.com> wrote:
> 
> 
>> On Fri, Dec 19, 2014 at 5:23 PM, Justin Bogner <mail at justinbogner.com> wrote:
>> Because they check for the output they want (or don't, as the case may
>> be), rather than checking for no output. Please use FileCheck for this:
>> 
>>     ; CHECK-NOT: not a recognized processor for this target
>>     ; RUN: llc < %s -o /dev/null -mtriple=x86_64-unknown-unknown -mcpu=nocona 2>&1 | FileCheck --allow-empty
> 
> I actually started with this and specifically avoided it because it will silently miss if the error message changes its form at all.
> 
> But I think I see how to do this robustly now -- I can force it to fail and check that the error message in fact matches this first. I'll do that when I'm next at a computer with a checkout if no one gets there first.

That's a much better idea! Thanks.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141219/f62077bc/attachment.html>