[PATCH] [compiler-rt] log-path_test testcase - make the invalid path more invalid

Kuba Brecka kuba.brecka at gmail.com
Thu Dec 18 11:40:28 PST 2014


The ASan test/asan/TestCases/log-path_test.cc testcase uses `/INVALID` as an invalid path and expects that the program will not be allowed to create or write to that file. This actually is a valid writable path on one of my setups. Let's make the path more invalid.

http://reviews.llvm.org/D6727

Files:
  test/asan/TestCases/log-path_test.cc

Index: test/asan/TestCases/log-path_test.cc
===================================================================
--- test/asan/TestCases/log-path_test.cc
+++ test/asan/TestCases/log-path_test.cc
@@ -13,7 +13,7 @@
 // RUN: FileCheck %s --check-prefix=CHECK-ERROR < %t.log.*
 
 // Invalid log_path.
-// RUN: env ASAN_OPTIONS=log_path=/INVALID not %run %t 2> %t.out
+// RUN: env ASAN_OPTIONS=log_path=/dev/null/INVALID not %run %t 2> %t.out
 // RUN: FileCheck %s --check-prefix=CHECK-INVALID < %t.out
 
 // Too long log_path.
@@ -40,5 +40,5 @@
   return res;
 }
 // CHECK-ERROR: ERROR: AddressSanitizer
-// CHECK-INVALID: ERROR: Can't open file: /INVALID
+// CHECK-INVALID: ERROR: Can't open file: /dev/null/INVALID
 // CHECK-LONG: ERROR: Path is too long: 01234

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6727.17460.patch
Type: text/x-patch
Size: 759 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141218/6e7552b9/attachment.bin>


More information about the llvm-commits mailing list