[PATCH] [zorg] Add sanitizer-bootstrap-lite bot.

Evgeniy Stepanov eugenis at google.com
Wed Dec 17 07:40:06 PST 2014


In http://reviews.llvm.org/D6689#102388, @earthdok wrote:

> Another thing I don't understand is how fatal and non-fatal steps are configured. I.e. here:
>
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/14600
>
> we fail to build the host compiler, so all remaining steps are skipped. On the other hand, when a test fails, we still run the remaining steps:
>
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/5327
>
> Yet, it looks like in both cases the script looks exactly the same:
>
> (run_step) || echo @@@STEP_FAILURE@@@


No, in the first case the line is:
(cd clang_build && cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo \

  ${CMAKE_COMMON_OPTIONS} $LLVM_CHECKOUT)

And the script sets "-e", so a non-zero exit code in this line is fatal.

This could be made more consistent.


http://reviews.llvm.org/D6689

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list