[PATCH] Fix PR21694 - Revert improper use of divide in SCEV HowFarToZero computation

Andrew Trick atrick at apple.com
Thu Dec 11 01:26:10 PST 2014


Sorry I didn't respond. I wasn't able to easily convince myself that this fixes the problem. Since this reverts to the previous implementation, I think it's a good change. But the code is written in a way that is extremely hard to reason about.

For example:

- StepV could be negative but still be a power of two, is this expected?

- Why are we checking GetMinTrailingZeros(getNegativeSCEV(Start)) instead of GetMinTrailingZeros(Distance)?

If we can only handle counting up here, lets be more clear about that.


http://reviews.llvm.org/D6546

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list