[PATCH] [AArch64] MachO large code-model: Materialize FP constants in code.

Tim Northover t.p.northover at gmail.com
Wed Dec 10 11:27:56 PST 2014


Hi Juergen,

On 10 December 2014 at 11:13, Juergen Ributzka <juergen at apple.com> wrote:
> I attached an updated patch, which is now much simpler.

Excellent. Just one comment on the updated patch. It seems fine otherwise:

+    unsigned Opc2 = Is64Bit ? AArch64::FMOVXDr : AArch64::FMOVWSr;
+    unsigned ResultReg = createResultReg(TLI.getRegClassFor(VT));
+    BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, DbgLoc, TII.get(Opc2), ResultReg)
+        .addReg(TmpReg, getKillRegState(true));

This bit of FastISel can just emit a generic COPY node, it'll be
handled by copyPhysReg, and might even be elided in some slightly
weird situations.

Cheers.

Tim.



More information about the llvm-commits mailing list