New Iteration of subregister liveness patches

Matthias Braun matze at braunis.de
Wed Dec 10 10:31:09 PST 2014


> On Dec 10, 2014, at 9:28 AM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> 
> 
> On Tue, Dec 9, 2014 at 5:32 PM, Matthias Braun <matze at braunis.de <mailto:matze at braunis.de>> wrote:
> Ok,
> 
> I just commited the changes to svn trunk. Thanks everyone, esp. Renato and Quentin, for the detailed reviews!
> 
> SubRegisterLiveness is available as a subtarget switch now, but not enabled by any of the targets yet, as most of them need some additional fixing/testcase changes which I'll address in subsequent commits.
> 
> For the record: I did fix many but not all issues mentioned in the reviews. The following is still missing:
> 
> - Manually creating a single linked list in the LiveInterval class. The alternatives to this are:
>     a) Using the double linked list provided by llvm.
>     b) Turning the manual single linked list into a full featued ADT in llvm.
> 
> Why not std::forward_list ?

As far as I know the STL list containers are non-intrusive which is probably even more wasteful as you need an extra object (with memory allocator alignment padding) for each list element.

- Matthias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141210/fd070619/attachment.html>


More information about the llvm-commits mailing list