[PATCH] DW_OP_const* is invalid as a location

[David Blaikie]

On Tue, Dec 9, 2014 at 9:37 PM, Katya Romanova <
Katya_Romanova at playstation.sony.com> wrote:

> ================
> Comment at: test/DebugInfo/incorrect-variable-debugloc1.ll:6
> @@ +5,3 @@
> +
> +; This is a test for BZ #21176.
> +; DW_OP_const <const> doesn't describe a constant value, but a value at a
> constant address.
> ----------------
> dblaikie wrote:
> > Usually we write this as "PR21176" (rather than "BZ #21176").
> I will make this change in the comment before I commit. I guess, It might
> make the grep more consistent.
> I don't see any benefit in uploading one more review for this reason only.
>
> Is it OK to commit or should I wait to make sure that Fred and Eric don't
> have any additional comments?
> Katya.
>

It's OK to commit - as you can see in Phab, I "approved" the change, which
generally means you're good to commit. Other people can provide post-commit
review feedback if there's more followup needed.


>
> ================
> Comment at: test/DebugInfo/incorrect-variable-debugloc1.ll:22
> @@ +21,3 @@
> +
> +; DWARF23: Location description: 10 0d
> +; DWARF4: Location description: 10 0d 9f
> ----------------
> dblaikie wrote:
> > You probably need a {{$}} at the end of this line, otherwise it'll pass
> even if we emit the DWARF4 form here (test this by removing the conditional
> in your fix and observing that this test doesn't fail where it should)
> You are right. I'll fix it.
>
> http://reviews.llvm.org/D6568
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141210/e57b79b1/attachment.html>