[PATCH] Add per-test timeouts to lit

Daniel Dunbar daniel at zuster.org
Tue Dec 9 16:15:25 PST 2014


I would love to have this feature, so +1 on that.

I would prefer that it not introduce a new failure code though, and just
use FAIL with some extra message output.

It might be worth considering whether or not we should run the subprocesses
in their own process group if this is enabled, so that we can kill the
entire process group. I'm not sure if there is any downside to that, and I
would like to guarantee that if we have timeouts we never accidentally
leave a stray runaway subprocess, which might otherwise bog down a CI setup.

It looks like you are doing some more work on this so I will hold further
review until then.

 - Daniel


On Tue, Dec 9, 2014 at 1:58 PM, Jonathan Roelofs <jonathan at codesourcery.com>
wrote:

> Hi ddunbar, EricWF,
>
> This is different than the option '--max-time', which limits total testing
> time.
>
> http://reviews.llvm.org/D6584
>
> Files:
>   lit/LitConfig.py
>   lit/Test.py
>   lit/TestRunner.py
>   lit/formats/base.py
>   lit/main.py
>   lit/run.py
>   lit/util.py
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141209/35570a52/attachment.html>


More information about the llvm-commits mailing list