[llvm] r223802 - IR: Split Metadata from Value

[Duncan P. N. Exon Smith]

> On 2014 Dec 9, at 15:13, Reid Kleckner <rnk at google.com> wrote:
> 
> On Tue, Dec 9, 2014 at 12:40 PM, Hans Wennborg <hans at chromium.org> wrote:
> It seems to have helped, but now it fails with:
> 
> ..\lib\Linker\LinkModules.cpp(1315) : error C2593: 'operator !=' is ambiguous
>         could be 'built-in C++ operator!=(bool, bool)'
>         or       'built-in C++ operator!=(llvm::Metadata *, llvm::Metadata *)'
>         while trying to match the argument list '(const llvm::MDOperand, const l
> lvm::MDOperand)'
> ..\lib\Linker\LinkModules.cpp(1340) : error C2593: 'operator !=' is ambiguous
>         could be 'built-in C++ operator!=(bool, bool)'
>         or       'built-in C++ operator!=(llvm::Metadata *, llvm::Metadata *)'
>         while trying to match the argument list '(const llvm::MDOperand, const l
> lvm::MDOperand)'
> ..\lib\Linker\LinkModules.cpp(1348) : error C2593: 'operator !=' is ambiguous
>         could be 'built-in C++ operator!=(bool, bool)'
>         or       'built-in C++ operator!=(llvm::Metadata *, llvm::Metadata *)'
>         while trying to match the argument list '(const llvm::MDOperand, const l
> lvm::MDOperand)'
> 
> 
> I've committed my attempt in r223824.
> 
> Everything builds for me, but I get lots of crashes in CGDebugInfo.cpp in the test suite now when building with MSVC. I'll try to get more information soon.

You're CC'ed on PR21798, which I assume is related.

There seems to be a double-free on hexagon [1] that I haven't been
able to repro... if I'm really lucky, my latest speculative fix
(r223849) is the answer to both.

[1]: http://lab.llvm.org:8011/buildslaves/hexagon-build-03