[PATCH] DW_OP_const* is invalid as a location

[Frederic Riss]

This is mostly OK, just some small nits:

================
Comment at: test/DebugInfo/incorrect-variable-debugloc1.ll:7
@@ +6,3 @@
+; This is a test for BZ #21176.
+; DW_OP_const <const> is not a valid DWARF location. 
+; The proper way to describe a case where a value is constant  
----------------
I'd say 'doesn't describe a constant value, but a value at a constant address'. AFAIK, the location is valid, it's just not what we want to describe :-)

================
Comment at: test/DebugInfo/incorrect-variable-debugloc1.ll:27-28
@@ +26,4 @@
+; ModuleID = 'test.cpp'
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
----------------
We usually edit these out when the testcase is target independent (And otherwise it should go to a target specific directory)

http://reviews.llvm.org/D6568