[PATCH] AVX-512 Intrinsics for ER instructions

Demikhovsky, Elena elena.demikhovsky at intel.com
Mon Dec 8 23:14:22 PST 2014


Thank you.
Committed revision 223761

-  Elena


-----Original Message-----
From: Adam Nemet [mailto:anemet at apple.com] 
Sent: Monday, December 08, 2014 20:17
To: Demikhovsky, Elena; anemet at apple.com; rob.khasanov at gmail.com
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] AVX-512 Intrinsics for ER instructions

================
Comment at: lib/Target/X86/X86InstrAVX512.td:5
@@ -4,2 +4,3 @@
 // individual arguments.
+// The template is also used for scalar types, in this case numelts is 1.
 class X86VectorVTInfo<int numelts, ValueType EltVT, RegisterClass rc,
----------------
Please also mention that for scalar types we map them to the smallest (128-bit) vector type with  the same element type.  And the motivation: so that masking logic can be transferred to them.

LGTM with something like that.

http://reviews.llvm.org/D6214


---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.




More information about the llvm-commits mailing list