[PATCH] DW_OP_const* is invalid as a location

Eric Christopher echristo at gmail.com
Mon Dec 8 13:14:06 PST 2014


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1721
@@ -1720,2 +1720,3 @@
       Streamer.EmitSLEB128(Value.getInt());
+      Streamer.EmitInt8(dwarf::DW_OP_stack_value, "DW_OP_stack_value");
     } else {
----------------
dblaikie wrote:
> dblaikie wrote:
> > Should this just go outside the if/else, so it's written once rather than twice?
> Do we need to conditionalize this based on whether we're emitting DWARF >= 4? And just leave it the old/broken way in DWARF < 4 for old consumers to keep guessing the way they have before (like LLDB)?
Seems the most reasonable thing to do, yes.

http://reviews.llvm.org/D6568






More information about the llvm-commits mailing list