[PATCH] [mips] Enable code generation for MIPS-III.

Daniel Sanders daniel.sanders at imgtec.com
Mon Dec 8 07:29:52 PST 2014


LGTM with a style nit and with the DecoderNamespace's removed (if they aren't really needed).

================
Comment at: lib/Target/Mips/MipsCondMov.td:287-288
@@ -286,2 +286,4 @@
 def PseudoSELECT_I : Select_Pseudo<GPR32Opnd>;
+let DecoderNamespace = "Mips64" in
+def PseudoSELECT_I64 : Select_Pseudo<GPR64Opnd>;
 def PseudoSELECT_S : Select_Pseudo<FGR32Opnd>;
----------------
Style nit:
  def PseudoSELECT_I64 : Select_Pseudo<GPR64Opnd> {
    let DecoderNamespace = "Mips64" in
  }
is preferable if the let only applies to a single def. Similarly below.

One related question is: Is it necessary to set the DecoderNamespace? As far as I know it only affects the disassembler tables and pseudo's aren't included in those tables.

http://reviews.llvm.org/D6464






More information about the llvm-commits mailing list