[PATCH] [ASan] Refactor thread starting code.

Sergey Matveev earthdok at google.com
Fri Dec 5 09:32:01 PST 2014


Committed r223483

================
Comment at: lib/asan/asan_interceptors.cc:201
@@ -200,3 @@
-    AsanThread *t = AsanThread::Create(start_routine, arg);
-    CreateThreadContextArgs args = { t, &stack };
-    asanThreadRegistry().CreateThread(*reinterpret_cast<uptr *>(t), detached,
----------------
samsonov wrote:
> Can we remove CreateThreadContextArgs from asan_thread.h header now?
done

================
Comment at: lib/asan/asan_interceptors.cc:735
@@ -739,1 +734,3 @@
+  AsanThread *t =
+      AsanThread::Create(start_routine, arg, current_tid, stack, detached);
   return REAL(CreateThread)(security, stack_size,
----------------
samsonov wrote:
> s/stack/&stack
done

http://reviews.llvm.org/D6544






More information about the llvm-commits mailing list