[llvm] r221960 - IR: Rewrite uniquing and creation of MDString

[Alexey Samsonov]

On Thu, Dec 4, 2014 at 5:43 PM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

>
> > On 2014-Dec-04, at 17:10, Duncan P. N. Exon Smith <dexonsmith at apple.com>
> wrote:
> >
> >> On 2014-Dec-04, at 15:44, Alexey Samsonov <vonosmas at gmail.com> wrote:
> >>
> >> FYI, StringMapEntry<>::GetStringMapEntryFromValue is inherently broken
> - I've failed to fix it in r223402, but failed. We can't just "get the
> offset" of a non-standard-layout object field.
> >
> > Crap.
> >
> >> I'd be happy to delete GetStringMapEntryFromValue from the codebase
> completely, but currently MDString::getString() is its only user.
> >>
> >
> > I'll remove that use, and kill the function myself.  Thanks.
>
> r223438 and r223439.  Sorry I missed the bot failure (if there was one).
>

Thank you!

-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141204/d914b92c/attachment.html>