[PATCH] ELF: Add a standard method for unknown relocation errors

Simon Atanasyan simon at atanasyan.com
Thu Dec 4 05:18:19 PST 2014


Good idea. Did you consider to factor out the `unhandledReferenceType` method into the separate class? Some sort of `Diagnostic`. The `LinkingContext` might have a reference to this class. That allow us to keep all diagnostics stuff together and simplify implementation of  feature-rich diagnostics engine in the future.

================
Comment at: lib/ReaderWriter/ELF/Mips/MipsRelocationHandler.h:24
@@ +23,3 @@
+                              ELFLinkingContext &targetInfo)
+    : TargetRelocationHandler<Mips32ElELFType>(targetInfo),
+    _mipsTargetLayout(layout) {}
----------------
Are these lines clang-formatted?

http://reviews.llvm.org/D6523






More information about the llvm-commits mailing list