[PATCH] [Mips][ABI]The ELF container needs to depend on the ABI rather than the target triple.

Vladimir Medic Vladimir.Medic at imgtec.com
Tue Dec 2 01:15:01 PST 2014


Hi dsanders, sstankovic,

At the moment Mips back-end is deciding between ELF32/64 output based on target triple. We should instead use ABI which should be passed as -target-abi command line option. This is the patch that has been created on the bases of http://reviews.llvm.org/D6092 and updated to the top of the tree with no functional changes, subscribers added as requested in initial patch. It is still missing the test files, but we'd like to keep it short at the time until the remaining issues are solved. We still looking where would it be the best to initialize and store the ABI info value so that it's accessible from codegen, the integrated assembler, and the disassembler. Also, selectMipsCPU is currently a member of MipsABIInfo class which is not a best logical place for it, but it is placed there to be visible to all calling classes to avoid code multiplication.

http://reviews.llvm.org/D6476

Files:
  lib/Target/Mips/AsmParser/MipsAsmParser.cpp
  lib/Target/Mips/CMakeLists.txt
  lib/Target/Mips/Disassembler/MipsDisassembler.cpp
  lib/Target/Mips/MCTargetDesc/CMakeLists.txt
  lib/Target/Mips/MCTargetDesc/MipsABIInfo.cpp
  lib/Target/Mips/MCTargetDesc/MipsABIInfo.h
  lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp
  lib/Target/Mips/MCTargetDesc/MipsAsmBackend.h
  lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp
  lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.cpp
  lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.h
  lib/Target/Mips/MCTargetDesc/MipsOptionRecord.cpp
  lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp
  lib/Target/Mips/Mips.td
  lib/Target/Mips/MipsABIInfo.cpp
  lib/Target/Mips/MipsABIInfo.h
  lib/Target/Mips/MipsAsmPrinter.cpp
  lib/Target/Mips/MipsInstrInfo.td
  lib/Target/Mips/MipsOptionRecord.h
  lib/Target/Mips/MipsSubtarget.cpp
  lib/Target/Mips/MipsSubtarget.h
  lib/Target/Mips/MipsTargetStreamer.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6476.16803.patch
Type: text/x-patch
Size: 35026 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141202/871d2698/attachment.bin>


More information about the llvm-commits mailing list