[PATCH] Simplify Symbolizer::SymbolizePC() interface.

Alexey Samsonov vonosmas at gmail.com
Mon Dec 1 12:30:17 PST 2014


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer.cc:56
@@ +55,3 @@
+    next->ClearAll();
+    next = nullptr;
+  }
----------------
dvyukov wrote:
> who is deallocating next?
OMG. Fixed.

================
Comment at: lib/tsan/rtl/tsan_rtl_report.cc:75
@@ -75,1 +74,3 @@
+    last_frame->ClearAll();
+    last_frame2->next = nullptr;
   // Strip our internal thread start routine.
----------------
dvyukov wrote:
> who is deallocating last_frame?
> here and below
Fixed (now this is done by ClearAll()) function.

================
Comment at: lib/tsan/rtl/tsan_symbolize.cc:58
@@ -57,3 +57,3 @@
 
-ReportStack *SymbolizeCode(uptr addr) {
+SymbolizedFrame *SymbolizeCode(uptr addr) {
   // Check if PC comes from non-native land.
----------------
dvyukov wrote:
> SymbolizedFrame is somewhat confusing here, because it is whole stack rather than a single frame.
> I would s/SymbolizedFrame/SymbolizedStack/
Done.

http://reviews.llvm.org/D6394






More information about the llvm-commits mailing list