[lld] r222983 - [Core] Add flag to check if RoundTripPasses need to be run.

Shankar Easwaran shankare at codeaurora.org
Mon Dec 1 12:11:55 PST 2014


On 12/1/2014 2:04 PM, Rui Ueyama wrote:
> I'm not sure if I got what you mean... So, just to make sure we are on the
> same page, the reason to have the round-trip passes is to make sure all
> output can be serialized and de-serialized, right? I think you added these
> tests because of that reason.
>
> Because the YAML/Native are guaranteed compatible, we can dump an
> intermediate results to YAML/Native files and then resume processing by
> reading them back.
>
> And then looks like you are now adding a way to bypass that. So they are no
> longer compatible. That is exactly what you wanted to avoid, no?
Yes, I thought of adding a way to bypass that but you are right, we 
should not allow the RoundTripPasses to be bypassed. I will remove the 
setRunRoundTripPass function in LinkingContext.

But I do need lld to preserve the filename of the atom using references 
if the round trip passes were going to be run. So the reader and the 
writer would read the information using references if the round trip 
passes were being run.

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation




More information about the llvm-commits mailing list