[PATCH] Fix Windows build

[Robinson, Paul]

+Jordan as he's the last one to muck with GetSVN.cmake.

From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Robinson, Paul
Sent: Sunday, November 30, 2014 1:58 PM
To: Sean Silva
Cc: llvm-commits at cs.uiuc.edu
Subject: RE: [PATCH] Fix Windows build

I have attached the output with a git-svn repo on Mac. Looks fine
Thanks for testing it!  (But you didn't actually say LGTM so leaving this open.)
(except for the awkwardness of calling the macros SVN_REVISION and SVN_REPOSITORY; could you change the name of those in a follow-on patch?).
The GetSVN.cmake script doesn't decide on those names; they're determined by the caller.
In this case the generated header is private to clang/lib/Basic and IIRC is used by only one module within Basic; so I don’t see any value in changing the names.
They refer to "our (i.e. clang's) SVN revision, and that other project's (i.e. LLVM's) SVN revision."  Seems clear enough to me in context.
--paulr

From: Sean Silva [mailto:chisophugis at gmail.com]
Sent: Wednesday, November 26, 2014 5:47 PM
To: Robinson, Paul
Cc: llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
Subject: Re: [PATCH] Fix Windows build

I have attached the output with a git-svn repo on Mac. Looks fine (except for the awkwardness of calling the macros SVN_REVISION and SVN_REPOSITORY; could you change the name of those in a follow-on patch?).

-- Sean Silva

On Wed, Nov 26, 2014 at 5:09 PM, Robinson, Paul <Paul_Robinson at playstation.sony.com<mailto:Paul_Robinson at playstation.sony.com>> wrote:
Revised patch that I'm pretty sure will handle straight git.
I'd appreciate somebody trying it with a git-svn clone, though.
Thanks,
--paulr

> -----Original Message-----
> From: Robinson, Paul
> Sent: Wednesday, November 26, 2014 4:15 PM
> To: Robinson, Paul; llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
> Subject: RE: [PATCH] Fix Windows build
>
> With patch...
>
> > -----Original Message-----
> > From: llvm-commits-bounces at cs.uiuc.edu<mailto:llvm-commits-bounces at cs.uiuc.edu> [mailto:llvm-commits-<mailto:llvm-commits->
> > bounces at cs.uiuc.edu<mailto:bounces at cs.uiuc.edu>] On Behalf Of Robinson, Paul
> > Sent: Wednesday, November 26, 2014 4:12 PM
> > To: llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
> > Subject: [PATCH] Fix Windows build
> >
> > r222391 updated GetSVN.cmake to run the LLVM helper scripts
> > GetSourceVersion
> > and GetRepositoryPath.  However, being shell scripts, they work only on
> > Unix-y hosts; on Windows they don't work, you end up with an
> > SVNVersion.inc
> > that looks like this:
> >
> > #define LLVM_REVISION ""
> > #define LLVM_REPOSITORY ""
> > #define SVN_REVISION ""
> > #define SVN_REPOSITORY ""
> >
> > I've rewritten the scripts as best I can into CMake so they will work on
> > Windows as well.  Now I get a better-looking SVNVersion.inc:
> >
> > #define LLVM_REVISION "222770"
> > #define LLVM_REPOSITORY "http://llvm.org/svn/llvm-project/llvm/trunk"
> > #define SVN_REVISION "222770"
> > #define SVN_REPOSITORY "http://llvm.org/svn/llvm-project/cfe/trunk"
> >
> > I can only test it on SVN, but I was able to clone code from another
> > CMake script so I'm pretty hopeful that it works for Git as well.
> >
> > Thanks,
> > --paulr
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141201/70bec308/attachment.html>