[PATCH] [compiler-rt] Implement AddressSanitizer suppressions

Kuba Brecka kuba.brecka at gmail.com
Thu Nov 27 21:41:14 PST 2014


Addressing review comments. Moved the sanitizer_suppressions changes into a separate patch (http://reviews.llvm.org/D6443), also used the not-yet-committed Symbolizer::SymbolizePC refactoring (http://reviews.llvm.org/D6394).

The suppression method is now split into two, so we're taking the stackshot in the actual interceptors (and not inside the suppression mechanism) and passing it to the second method. Let me know if you feel the other alternative (something like `MaybeReportInterceptorError()`) would be a better solution. I also removed the reporting about matched suppressions. Do you think we should keep it and have it print only under verbosity>=1?

Thanks for the review!

http://reviews.llvm.org/D6280

Files:
  lib/asan/CMakeLists.txt
  lib/asan/asan_interceptors.cc
  lib/asan/asan_rtl.cc
  lib/asan/asan_suppressions.cc
  lib/asan/asan_suppressions.h
  lib/sanitizer_common/sanitizer_suppressions.cc
  lib/sanitizer_common/sanitizer_suppressions.h
  lib/sanitizer_common/tests/sanitizer_suppressions_test.cc
  test/asan/TestCases/Darwin/suppressions-darwin.cc
  test/asan/TestCases/suppressions-function.cc
  test/asan/TestCases/suppressions-instrumented-code.cc
  test/asan/TestCases/suppressions-interceptor.cc
  test/asan/TestCases/suppressions-library.cc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6280.16714.patch
Type: text/x-patch
Size: 32425 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141128/c9df3b3a/attachment.bin>


More information about the llvm-commits mailing list