[llvm] r222897 - Commit back the correct bits of r222760 (was r222538).

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Nov 27 14:48:03 PST 2014


On 27 November 2014 at 17:19, Joerg Sonnenberger
<joerg at britannica.bec.de> wrote:
> On Thu, Nov 27, 2014 at 04:44:31PM -0500, Rafael EspĂ­ndola wrote:
>> > But your change reverts JIT to the old broken status.
>>
>> It is common practice to revert a patch when they broke something.
>>
>> Your patch broke mc and changed the tests. I have reverted it added
>> back the fix for when using the large code model. You are more than
>> welcome to debug why Default and JITDefault get this far, as that is
>> probably the correct way to fix the JIT issue you were seeing.
>
> That doesn't justify committing an obviously not working patch either.

You can revert r222897 if you don't want a fix for just the large code
model. That was just me trying to be helpful.

You cannot revert r222896 as that would once more regress MC.

Cheers,
Rafael




More information about the llvm-commits mailing list