[llvm] r222897 - Commit back the correct bits of r222760 (was r222538).

Joerg Sonnenberger joerg at britannica.bec.de
Thu Nov 27 10:39:21 PST 2014


On Thu, Nov 27, 2014 at 05:13:56PM -0000, Rafael Espindola wrote:
> Author: rafael
> Date: Thu Nov 27 11:13:56 2014
> New Revision: 222897
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=222897&view=rev
> Log:
> Commit back the correct bits of r222760 (was r222538).
> 
> I also added a test.
> 
> Original message:
> 
> Allow FDE references outside the +/-2GB range supported by PC relative
> offsets for code models other than small/medium. For JIT application,
> memory layout is less controlled and can result in truncations
> otherwise.

Except that this is wrong again. E.g. for llvm-mc, CodeModel::Default is
always used. The original part of checking Small||Medium is correct --
those are the only code models that provide the 31bit/32bit limitation.
The architectural issue here is that CodeModel::Default and
CodeModel::JITDefault are only overwritten during codegen creation.
Should they be attributes of the Target? Can they change with the ABI?

Joerg



More information about the llvm-commits mailing list