[llvm] r222760 - Reapply 222538 and update tests to explicitly request small code model

[Rafael Espíndola]

On 27 November 2014 at 11:38, Joerg Sonnenberger
<joerg at britannica.bec.de> wrote:
> On Thu, Nov 27, 2014 at 11:30:40AM -0500, Rafael Espíndola wrote:
>> On 27 November 2014 at 11:16, Joerg Sonnenberger
>> <joerg at britannica.bec.de> wrote:
>> > On Thu, Nov 27, 2014 at 11:01:54AM -0500, Rafael Espíndola wrote:
>> >> This is odd at least.
>> >>
>> >> First,  -code-model=smal is the default, please don't specify it everywhere.
>> >> Second, why the PIC change? The gnu assembler always uses a
>> >> DW_EH_PE_pcrel encoding. What is the advantage of not doing that?
>> >
>> > I specified it explicitly to get a consistent value.
>>
>> It is consistent. It is the default and it is important that the small
>> model remains the default.
>
> It is still a hidden assumption.

And by removing it you failed to noticed this was also doing the wrong
thing for the Default code model enum.

I have reverted the patch. Applied only the originally intended change
and added the testcase it should have in the first place.

Please start a discussion on LLVMdev if you think we should change
behavior relative to gas.

Cheers,
Rafael