[PATCH] [PowerPC] Fix unwind info with dynamic stack realignment

Jay Foad jay.foad at gmail.com
Wed Nov 26 07:14:53 PST 2014


================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:737
@@ +736,3 @@
+      // terms of BP, because it's not at a fixed offset from SP.
+      // Otherwise, we could define it in terms of either BP or SP, but BP is
+      // easier because the offset is always zero.
----------------
willschm wrote:
> s/Otherwise, we/We/
The "otherwise" is there for a reason: we only get to choose between BP and SP if there has *not* been any dynamic stack realignment. I'm open to ideas for rewording the whole thing it it'll make it easier to understand.

http://reviews.llvm.org/D6410






More information about the llvm-commits mailing list