[PATCH] Initial contribution of llgo, a Go frontend

Andrew Wilkins axwalk at gmail.com
Tue Nov 25 02:08:02 PST 2014


================
Comment at: tools/llgo/debug/debug.go:387
@@ +386,3 @@
+func (d *DIBuilder) descriptorMap(t *types.Map, name string) llvm.Value {
+	return d.descriptorBasic(types.Typ[types.Uintptr], name)
+}
----------------
pcc wrote:
> ruiu wrote:
> > Is this TODO?
> Perhaps. I am not sure what the debug info for these should look like. @axw was the original author of this code.
Yes, sorry, please add a TODO/FIXME. This should be DW_TAG_pointer_type to __go_map.

I ran gllgo over some basic code and the current output isn't great. I'll submit a patch or two once this is in to improve that.

(Sorry, I wrote this comment shortly after seeing the above, didn't realise I hadn't submitted the reply.)

================
Comment at: tools/llgo/debug/debug.go:391
@@ +390,3 @@
+func (d *DIBuilder) descriptorChan(t *types.Chan, name string) llvm.Value {
+	return d.descriptorBasic(types.Typ[types.Uintptr], name)
+}
----------------
pcc wrote:
> ruiu wrote:
> > ditto
> Ditto
ditto :)

http://reviews.llvm.org/D6327






More information about the llvm-commits mailing list