[PATCH] Factor check for the assume intrinsic out of checks in computeKnownBitsFromAssume

hfinkel at anl.gov hfinkel at anl.gov
Mon Nov 24 13:41:10 PST 2014


LGTM. Thanks!

================
Comment at: lib/Analysis/ValueTracking.cpp:494
@@ -493,2 +493,3 @@
 
-    if (match(I, m_Intrinsic<Intrinsic::assume>(m_Specific(V))) &&
+    // Warning: This loop can end up being somewhat performance sensative.
+    // We're running this loop for once for each value queried resulting in a
----------------
sensative -> sensitive


================
Comment at: lib/Analysis/ValueTracking.cpp:498
@@ +497,3 @@
+
+    assert( isa<IntrinsicInst>(I) &&
+            dyn_cast<IntrinsicInst>(I)->getIntrinsicID() == Intrinsic::assume &&
----------------
No need for extra space after (

http://reviews.llvm.org/D6312






More information about the llvm-commits mailing list