[PATCH] PR21563: More Windows long-path support

[Robinson, Paul]

> -----Original Message-----
> From: Michael Spencer [mailto:bigcheesegs at gmail.com]
> Sent: Friday, November 21, 2014 4:46 PM
> To: Robinson, Paul
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [PATCH] PR21563: More Windows long-path support
> 
> On Fri, Nov 14, 2014 at 9:23 PM, Robinson, Paul
> <Paul_Robinson at playstation.sony.com> wrote:
> > Following up on my previous patch, implement long-path support in
> > Support\Windows\Program.inc for stdin/stdout/stderr redirection,
> > and (basically for completeness) naming the executable program.
> > Personally I think a long path for a program will never occur in
> > practice, but the Windows API supports it so might as well.
> >
> > The only other API that might be relevant and uses UTF8ToUTF16()
> > is findProgramByName; this would be relevant only for some caller
> > that passes the "Paths" parameter, which nothing in-tree does.
> > If somebody thinks we should make that API care about long paths,
> > let me know; it's an easy code change but way annoying to test.
> > (I don't see any existing test for findProgramByName.)
> >
> > If there's some call to a non-Unicode Windows API (and therefore
> > searching on UTF8ToUTF16() wouldn't find it) that uses paths,
> > let me know.
> > --paulr
> 
> Looks good to me.

r222671.

> 
> Sorry I missed this patch. In the future you should CC whoever you
> think would be good to review the patch.

Will do.
--paulr

> 
> - Michael Spencer