[PATCH] [mips][microMIPS] Implement LBU16, LHU16, LW16, SB16, SH16 and SW16 instructions

Sasa Stankovic Sasa.Stankovic at imgtec.com
Mon Nov 24 06:05:11 PST 2014


LGTM, with 2 changes.

================
Comment at: lib/Target/Mips/MicroMipsInstrInfo.td:193
@@ +192,3 @@
+
+class StoreMM16<string opstr, DAGOperand RTOpnd, DAGOperand RO,
+                SDPatternOperator OpNode, InstrItinClass Itin, Operand MemOpnd> :
----------------
This line doesn't fit in 80 columns.

================
Comment at: lib/Target/Mips/MicroMipsInstrInfo.td:364
@@ +363,3 @@
+                        mem_mm_4_lsl1>, LOAD_STORE_FM_MM16<0x0a>;
+def LW16_MM  : LoadMM16<"lw16", GPRMM16Opnd, load, II_LW, mem_mm_4_lsl2>,
+                       LOAD_STORE_FM_MM16<0x1a>;
----------------
Move this line one space to the right.

http://reviews.llvm.org/D5122






More information about the llvm-commits mailing list