[PATCH] PR21563: More Windows long-path support

Robinson, Paul Paul_Robinson at playstation.sony.com
Fri Nov 21 11:23:34 PST 2014


Ping.

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Robinson, Paul
> Sent: Friday, November 14, 2014 9:23 PM
> To: llvm-commits at cs.uiuc.edu
> Subject: [PATCH] PR21563: More Windows long-path support
> 
> Following up on my previous patch, implement long-path support in
> Support\Windows\Program.inc for stdin/stdout/stderr redirection,
> and (basically for completeness) naming the executable program.
> Personally I think a long path for a program will never occur in
> practice, but the Windows API supports it so might as well.
> 
> The only other API that might be relevant and uses UTF8ToUTF16()
> is findProgramByName; this would be relevant only for some caller
> that passes the "Paths" parameter, which nothing in-tree does.
> If somebody thinks we should make that API care about long paths,
> let me know; it's an easy code change but way annoying to test.
> (I don't see any existing test for findProgramByName.)
> 
> If there's some call to a non-Unicode Windows API (and therefore
> searching on UTF8ToUTF16() wouldn't find it) that uses paths,
> let me know.
> --paulr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: prog-abs.diff
Type: application/octet-stream
Size: 5621 bytes
Desc: prog-abs.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141121/2e140657/attachment.obj>


More information about the llvm-commits mailing list