[PATCH] [mips][microMIPS] Use call instructions with short delay slots

Sasa Stankovic Sasa.Stankovic at imgtec.com
Fri Nov 21 09:03:03 PST 2014


LGTM, with two changes.

================
Comment at: lib/Target/Mips/MipsDelaySlotFiller.cpp:550
@@ +549,3 @@
+        if (InMicroMipsMode && TII->GetInstSizeInBytes(std::next(DSI)) == 2 &&
+            DSI->isCall())
+          // If instruction in delay slot is 16b chenge opcode to
----------------
Typo "chenge". Also, I think it would improve readability if you add parenthesis, since code related to "if" occupies 3 lines.

================
Comment at: test/CodeGen/Mips/micromips-delay-slot.ll:16
@@ -18,1 +15,3 @@
+declare i32 @bar(i32 signext) #1
 
+; CHECK: jals
----------------
Since jals allows only 16-bits delay slot instructions, you should also CHECK that instruction in delay slot is 16-bits.

http://reviews.llvm.org/D6338






More information about the llvm-commits mailing list