[PATCH] [ASAN/AArch64] Fix kernel_old_Xid_t type

Evgeniy Stepanov eugenis at google.com
Fri Nov 21 05:25:18 PST 2014


We decided against inclusion of system headers into sanitizer interceptors because interceptors define functions with the same names as system functions (that's how interception works on linux). Such functions must have exactly the same signature to avoid compilation errors. Different version of libc define, for example, strchr with different signatures (with or without const on some of the arguments).

As for this aarch64 issue, my understanding is that there is no actual ABI change here. Just a bugfix in kernel headers. The actual syscall implementation has always been using 16-bit Xid_t. True?

In that case we could just relax the compile-time check under #ifdef __aarch64__. WDYT?

http://reviews.llvm.org/D6026






More information about the llvm-commits mailing list