[PATCH] Select Elimination in InstCombine

hfinkel at anl.gov hfinkel at anl.gov
Wed Nov 19 16:09:18 PST 2014


I think this is generally good (again). LGTM.

================
Comment at: lib/IR/Value.cpp:357
@@ +356,3 @@
+// Like replaceAllUsesWith except it does not handle constants or basic blocks.
+// This routine leaves uses within BB.
+void Value::replaceUsesOutsideBlock(Value *New, BasicBlock *BB) {
----------------
We don't need this description here, we have a better one in the header.

================
Comment at: lib/Transforms/InstCombine/InstCombineCompares.cpp:34
@@ +33,3 @@
+// How many times is a select replaced by one of its operands?
+STATISTIC(NumSel, "Number of select opts");
+
----------------
"Number of select opts" -> "Number of selects replaced by an operand"

http://reviews.llvm.org/D5258






More information about the llvm-commits mailing list