[PATCH] Improve RegisterCoalescer debugging experience

[Quentin Colombet]

On Nov 19, 2014, at 11:20 AM, Matthias Braun <matze at braunis.de> wrote:

> 
>> On Nov 19, 2014, at 9:43 AM, Quentin Colombet <qcolombet at apple.com> wrote:
>> 
>> Hi Matthias,
>> 
>> Thanks for working on this.
>> Here are my comments.
>> 
>>> 0001-Introduce-register-dump-helper.patch
>> 
>> I do not see in what dumpReg simplifies debugging compared to PrintReg.
>> Could you elaborate why do you think it is useful?
> The problem is that it is impossible to call ostream << object; on demand to inspect data in an lldb/gdb session (inlined operators not getting output to the object file I guess). So the simple solution is to add separate dump() functions to datastructures which you can also see in a bunch of other places in CodeGen.

Make sense.
I was a bit biased because I either look directly at PrintReg or TargetRegisterInfo::getName.

LGTM, then.

Thanks,
-Quentin

> 
> - Matthias