[PATCH] Use ninja pool to limit the number of concurrent compile/link jobs

Brad King brad.king at kitware.com
Tue Nov 18 06:06:33 PST 2014


On 11/18/2014 6:55 AM, Evgeniy Stepanov wrote:
> This change makes use of the new "job pool" capability in cmake 3.0.2

Great!

The job pool feature was added in CMake 3.0 and is in 3.0.0 too.

> +if(CMAKE_VERSION VERSION_GREATER 3.0.1 AND CMAKE_GENERATOR STREQUAL Ninja)

This condition should not be needed because setting the properties
on versions of CMake or generators that do not support them does
nothing anyway.  Instead you could just leave a comment that says
it only works with the Ninja generator and in CMake >= 3.0.

-Brad



More information about the llvm-commits mailing list