[llvm] r222233 - CallGraphTest.cpp: Remove invalid tests. ++S might step over F if S == F.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Nov 18 05:50:44 PST 2014


thanks

On 18 November 2014 07:23, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Author: chapuni
> Date: Tue Nov 18 06:23:19 2014
> New Revision: 222233
>
> URL: http://llvm.org/viewvc/llvm-project?rev=222233&view=rev
> Log:
> CallGraphTest.cpp: Remove invalid tests. ++S might step over F if S == F.
>
> MSVC Runtime detects "Assertion failed: vector iterator not incrementable"
>
> Modified:
>     llvm/trunk/unittests/Analysis/CallGraphTest.cpp
>
> Modified: llvm/trunk/unittests/Analysis/CallGraphTest.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Analysis/CallGraphTest.cpp?rev=222233&r1=222232&r2=222233&view=diff
> ==============================================================================
> --- llvm/trunk/unittests/Analysis/CallGraphTest.cpp (original)
> +++ llvm/trunk/unittests/Analysis/CallGraphTest.cpp Tue Nov 18 06:23:19 2014
> @@ -35,15 +35,12 @@ template <typename Ty> void canSpecializ
>
>    auto S = GraphTraits<NodeTy *>::child_begin(N);
>    auto F = GraphTraits<NodeTy *>::child_end(N);
> -  auto Y = ++S;
>
>    // Should be able to iterate over immediate successors of a node.
>    static_assert(std::is_same<decltype(*S), NodeTy *>::value,
>                  "Node type does not match");
>    static_assert(std::is_same<decltype(*F), NodeTy *>::value,
>                  "Node type does not match");
> -  static_assert(std::is_same<decltype(*Y), NodeTy *>::value,
> -                "Node type does not match");
>  }
>
>  TEST(CallGraphTest, GraphTraitsSpecialization) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list