[PATCH] Make sure BitcodeWriter works with Unicode characters

David Blaikie dblaikie at gmail.com
Thu Nov 13 10:30:36 PST 2014


I'm a bit confused why we're widening chars into 64 bit values - is there a quick explanation for that? (it seems inefficient to put one char in each 64 bit entry in Record, rather than putting 8 of them in there)

If Record is actually bytes, it has the wrong type, doesn't it - it should be SmallString, or SmallVector<uint8_t>, etc...

http://reviews.llvm.org/D6184






More information about the llvm-commits mailing list