[AVX512] Add 512b integer shift by immediate intrinsics

Cameron McInally cameron.mcinally at nyu.edu
Wed Nov 12 12:04:11 PST 2014


Hi Robert,

Committed with r221811.

I would like to get a separate internal approval for the masking
patterns, since that change touches a file not included in the
original patch. I'll submit a patch as soon as this is done. It
shouldn't take too long.

Thanks again,
Cam

On Tue, Nov 11, 2014 at 12:37 PM, Robert Khasanov
<rob.khasanov at gmail.com> wrote:
> Hi Cameron,
>
> LGTM, thank you!
> Probably, you will modify instructions in TD file to support masking
> patterns, I recommend to do these using AVX512_maskable multiclass.
>
>
>
> 2014-11-10 17:39 GMT+03:00 Cameron McInally <cameron.mcinally at nyu.edu>:
>>
>> Hey Robert,
>>
>> Please find an updated patch attached.
>>
>> Also, note that patterns will need to be added to match the masking
>> shift operations. I will have to address these in a separate patch.
>>
>> -Cameron
>>
>> On Fri, Nov 7, 2014 at 12:19 PM, Robert Khasanov <rob.khasanov at gmail.com>
>> wrote:
>> > Hi Cameron,
>> >
>> > Your AVX512 builtins don't support merge-masking and zero-masking
>> > versions.
>> > General, merge-masked and zero-masked Intel intrinsics will return one
>> > builtin with the different mask and passthrough args.
>> > Please add these arguments to your intrinsics, then you will need to
>> > create
>> > another intrinsic type (VSHIFT_MASK), and handle it using
>> > getVectorMaskingNode() function.
>> >
>> >
>> > 2014-11-07 2:24 GMT+03:00 Cameron McInally <cameron.mcinally at nyu.edu>:
>> >>
>> >> Hey guys,
>> >>
>> >> Here is a small patch to add 512b shift by immediate intrinsics.
>> >>
>> >> If everything is cool, I'll send a patch for shift by vector next.
>> >>
>> >> Thanks,
>> >> Cam
>> >
>> >
>
>



More information about the llvm-commits mailing list