[PATCH] [LIT] Add SuffixDispatchTest for use in libc++ and libc++abi tests.

Jonathan Roelofs jonathan at codesourcery.com
Wed Nov 12 08:16:26 PST 2014


================
Comment at: utils/lit/lit/formats/suffixdispatchtest.py:111
@@ +110,3 @@
+        if test_runner is None:
+            lit_config.fatal('Unrecognized test suffix: %s' % name)
+
----------------
EricWF wrote:
> jroelofs wrote:
> > When does this happen? Should it be an 'assert False'?
> lit_config.fatal will kill the process. This will happen when a test is matched to a suffix in config.suffixes but no test handler has been registered for that suffix.
Ah. A comment here explaining that might save someone a bit of head-scratching later.

http://reviews.llvm.org/D6206






More information about the llvm-commits mailing list