[llvm] r221758 - Make readBytes pure virtual. Every real implementation has it.

[Rafael Espindola]

Author: rafael
Date: Tue Nov 11 20:30:38 2014
New Revision: 221758

URL: http://llvm.org/viewvc/llvm-project?rev=221758&view=rev
Log:
Make readBytes pure virtual. Every real implementation has it.

Modified:
    llvm/trunk/include/llvm/Support/MemoryObject.h
    llvm/trunk/lib/Support/MemoryObject.cpp

Modified: llvm/trunk/include/llvm/Support/MemoryObject.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/MemoryObject.h?rev=221758&r1=221757&r2=221758&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/MemoryObject.h (original)
+++ llvm/trunk/include/llvm/Support/MemoryObject.h Tue Nov 11 20:30:38 2014
@@ -51,7 +51,8 @@ public:
   ///                   and large enough to hold size bytes.
   /// @result         - 0 if successful; -1 if not.  Failure may be due to a
   ///                   bounds violation or an implementation-specific error.
-  virtual int readBytes(uint64_t address, uint64_t size, uint8_t *buf) const;
+  virtual int readBytes(uint64_t address, uint64_t size,
+                        uint8_t *buf) const = 0;
 };
 
 }

Modified: llvm/trunk/lib/Support/MemoryObject.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/MemoryObject.cpp?rev=221758&r1=221757&r2=221758&view=diff
==============================================================================
--- llvm/trunk/lib/Support/MemoryObject.cpp (original)
+++ llvm/trunk/lib/Support/MemoryObject.cpp Tue Nov 11 20:30:38 2014
@@ -12,22 +12,3 @@ using namespace llvm;
   
 MemoryObject::~MemoryObject() {
 }
-
-int MemoryObject::readBytes(uint64_t address,
-                            uint64_t size,
-                            uint8_t* buf) const {
-  uint64_t current = address;
-  uint64_t limit = getExtent();
-
-  if (current + size > limit)
-    return -1;
-
-  while (current - address < size) {
-    if (readByte(current, &buf[(current - address)]))
-      return -1;
-    
-    current++;
-  }
-  
-  return 0;
-}