[llvm] r221598 - Mark test using python as REQUIRES: python27.

NAKAMURA Takumi geek4civic at gmail.com
Mon Nov 10 17:44:14 PST 2014


I noticed this is the 2nd script that uses %python in llvm/test. (1st
is BugPoint/compile-custom.ll)

I don't understand your background. What happened to you?
Could you update this to fit your environment? I am certain it'd be
safe even on 2.4.

Or, I hope you might work to disable this just on your environment.
It's not good idea to disable this on other (expected-to-work) hosts.

2014-11-11 1:07 GMT+09:00 Manuel Klimek <klimek at google.com>:
> Funnily enough it's not... (we're using our own lit runner).
> If you think it's wrong I can revert and just black-list the test internally
> though...
>
> On Mon Nov 10 2014 at 5:05:45 PM NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
>>
>> I assume python is required to build the tree.
>>
>> 2014-11-11 1:03 GMT+09:00 Manuel Klimek <klimek at google.com>:
>> > I have a test environment that doesn't have python... I need some way to
>> > mark this test to require python.
>> >
>> >
>> > On Mon Nov 10 2014 at 4:46:50 PM NAKAMURA Takumi <geek4civic at gmail.com>
>> > wrote:
>> >>
>> >> It should work with 2.6.6 and your "REQUIRES: python27" disables this
>> >> around whole version of python. What was your issue?
>> >>
>> >> 2014-11-11 0:29 GMT+09:00 Manuel Klimek <klimek at google.com>:
>> >> > Author: klimek
>> >> > Date: Mon Nov 10 09:29:29 2014
>> >> > New Revision: 221598
>> >> >
>> >> > URL: http://llvm.org/viewvc/llvm-project?rev=221598&view=rev
>> >> > Log:
>> >> > Mark test using python as REQUIRES: python27.
>> >> >
>> >> > Modified:
>> >> >     llvm/trunk/test/tools/llvm-symbolizer/ppc64.test
>> >> >
>> >> > Modified: llvm/trunk/test/tools/llvm-symbolizer/ppc64.test
>> >> > URL:
>> >> >
>> >> > http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-symbolizer/ppc64.test?rev=221598&r1=221597&r2=221598&view=diff
>> >> >
>> >> >
>> >> > ==============================================================================
>> >> > --- llvm/trunk/test/tools/llvm-symbolizer/ppc64.test (original)
>> >> > +++ llvm/trunk/test/tools/llvm-symbolizer/ppc64.test Mon Nov 10
>> >> > 09:29:29
>> >> > 2014
>> >> > @@ -1,3 +1,4 @@
>> >> > +// REQUIRES: python27
>> >> >  // ppc64 was compiled from this source on a big-endian 64-bit
>> >> > PowerPC
>> >> > box
>> >> >  // with just "clang -nostdlib":
>> >> >  int foo() { return 0; }
>> >> >
>> >> >
>> >> > _______________________________________________
>> >> > llvm-commits mailing list
>> >> > llvm-commits at cs.uiuc.edu
>> >> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list