[lld] r221650 - [ELF] Change order of section match.

Shankar Easwaran shankare at codeaurora.org
Mon Nov 10 16:43:52 PST 2014


Yes. I will do that. Thanks for the review.

Shankar Easwaran

On 11/10/2014 6:41 PM, David Blaikie wrote:
> On Mon, Nov 10, 2014 at 4:40 PM, Shankar Easwaran <shankare at codeaurora.org>
> wrote:
>
>> Author: shankare
>> Date: Mon Nov 10 18:40:38 2014
>> New Revision: 221650
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=221650&view=rev
>> Log:
>> [ELF] Change order of section match.
>>
>> Addressed comments from Sean silva.
>>
> Should this be covered by a test case of some kind?
>
>
>> Modified:
>>      lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h
>>
>> Modified: lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h?rev=221650&r1=221649&r2=221650&view=diff
>>
>> ==============================================================================
>> --- lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h (original)
>> +++ lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h Mon Nov 10 18:40:38 2014
>> @@ -360,8 +360,8 @@ Layout::SectionOrder DefaultLayout<ELFT>
>>           .StartsWith(".init_array", ORDER_INIT_ARRAY)
>>           .StartsWith(".fini_array", ORDER_FINI_ARRAY)
>>           .StartsWith(".dynamic", ORDER_DYNAMIC)
>> -        .StartsWith(".got", ORDER_GOT)
>>           .StartsWith(".got.plt", ORDER_GOT_PLT)
>> +        .StartsWith(".got", ORDER_GOT)
>>           .Default(ORDER_DATA);
>>
>>     case DefinedAtom::typeZeroFill:
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation




More information about the llvm-commits mailing list